[Gross] Makefile cleanup for installing grossd.conf

Nuutti Kotivuori naked at iki.fi
Tue Apr 15 14:26:19 EEST 2008


I found this bit in the Makefile.am:

          if test ! -f $(sysconfdir)/grossd.conf; then $(INSTALL_DATA) $(srcdir)/doc/examples/grossd.conf $(sysconfdir); fi

As a minor point, I dislike the test for existence of grossd.conf.
Sure, that's handy when testing and developing, but those sorts of
things in the Makefile make things hard for the package maintainers -
and can confuse some users.

But the real problem is that the commandline doesn't take in to
account $(DESTDIR).

It should be:

          if test ! -f $(DESTDIR)$(sysconfdir)/grossd.conf; then $(INSTALL_DATA) $(srcdir)/doc/examples/grossd.conf $(DESTDIR)$(sysconfdir); fi

Or just the same without the test for existence before.

Without this fix, installing with DESTDIR causes probably a permission
error from the system install location - and in any case the
configuration file lands up outside the directory specified.

-- Naked

More information about the Gross mailing list