[Gross] Makefile cleanup for installing grossd.conf
eino at utu.fi
Tue Apr 15 15:01:18 EEST 2008
Nuutti Kotivuori wrote:
> I found this bit in the Makefile.am:
> if test ! -f $(sysconfdir)/grossd.conf; then $(INSTALL_DATA) $(srcdir)/doc/examples/grossd.conf $(sysconfdir); fi
> As a minor point, I dislike the test for existence of grossd.conf.
> Sure, that's handy when testing and developing, but those sorts of
> things in the Makefile make things hard for the package maintainers -
> and can confuse some users.
Can you give me an example, please. I have thought that overwriting
existing config would make things even more confusing, when upgrading.
> But the real problem is that the commandline doesn't take in to
> account $(DESTDIR).
> It should be:
> if test ! -f $(DESTDIR)$(sysconfdir)/grossd.conf; then $(INSTALL_DATA) $(srcdir)/doc/examples/grossd.conf $(DESTDIR)$(sysconfdir); fi
Thats a bug, thanks for pointing it out! I'll fix it shortly.
More information about the Gross