[Gross] gross-1.0.1 milter and rhsbl ?

Jarno Huuskonen Jarno.Huuskonen at uku.fi
Mon Sep 29 11:59:33 EEST 2008


Hello,

I noticed small problem how grossd+milter handles email addresses
and rhsbl:
- if the smtp client sends addresses like: <sombody at example.com>, then
  grossd parses the domain: example.com> and queries rhsbl lists:
  example.com>.rhsbl.sorbs.net

This probably doesn't happen w/postfix: If I understand the protocol
description (http://www.postfix.org/SMTPD_POLICY_README.html) postfix
sends the domain/address w/out <> ?

Perhaps grossd should in (check_dnsbl.c:dnsblc) check if the sender
domain ends with '>' --> and remove the trailing '>' ?



Also, something like this might give a better error message when
the config file is not readable:
diff -urN gross-1.0.1.orig/src/conf.c gross-1.0.1/src/conf.c
--- gross-1.0.1.orig/src/conf.c 2008-05-15 17:21:50.000000000 +0300
+++ gross-1.0.1/src/conf.c      2008-09-26 18:32:33.000000000 +0300
@@ -323,8 +323,10 @@
        /* open configfile for reading */
        fd = open(filename, O_RDONLY);
 
-       if (fd < 0)
+       if (fd < 0) {
+               fprintf(stderr, "Can't open configfile: %s\n", filename);
                return config;
+       }
 
        /*
         * Process the config file.

-Jarno

-- 
Jarno Huuskonen



More information about the Gross mailing list